perf: small wins — static bytes and inline hints - #108
Merged
Conversation
serialize_sub_response now takes &'static [u8] for the event kind, using Bytes::from_static() instead of Bytes::copy_from_slice(). eliminates one heap allocation per subscribe/unsubscribe response.
annotates Frame::serialize(), write_i64(), and parse_frame() for cross-crate inlining. these are called on every request and sit at the protocol-server crate boundary where the compiler won't inline without the hint (even with LTO, #[inline] is the correct signal for functions this hot).
kacy
added a commit
that referenced
this pull request
Feb 19, 2026
* perf: use Bytes::from_static for pub/sub event type strings serialize_sub_response now takes &'static [u8] for the event kind, using Bytes::from_static() instead of Bytes::copy_from_slice(). eliminates one heap allocation per subscribe/unsubscribe response. * perf: add #[inline] to hot-path protocol functions annotates Frame::serialize(), write_i64(), and parse_frame() for cross-crate inlining. these are called on every request and sit at the protocol-server crate boundary where the compiler won't inline without the hint (even with LTO, #[inline] is the correct signal for functions this hot).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
tier 3 performance optimizations from the throughput/latency audit. low effort, low risk.
serialize_sub_responsenow takes&'static [u8]for the event kind, eliminating one heap allocation per subscribe/unsubscribe response. the channel name still usescopy_from_slicesince it's dynamicFrame::serialize(),write_i64(), andparse_frame()for cross-crate inlining. these are called on every single request and sit at the protocol → server crate boundarywhat was tested
cargo test --workspace --features protobuf— all tests passcargo clippy --workspace --features protobuf -- -D warnings— clean